On Sun, Jul 24, 2011 at 01:07, Gwynne Raskind <gwy...@darkrainfall.org> wrote: > Here's my question - if I made some smaller commits here and there to > fix warnings in core, would that be accepted? I don't have time to do > sweeping changes, but fixing one file today, a couple the next day, > etc., is within my abilities (including making sure no regressions are > introduced, of course).
Why on earth would anyone complain about such commit from an already-trusted-person-with-karma? If you start flooding the commit list with one-liners, people will probably complain. But if you are willing to do the extensive work needed to fix several warnings per commit.. I personally wouldn't commit such patch from 3rd party. Reverting such commit from a person I trust however wouldn't come to mind. Cursory review would be all *I* would do. Can't speak for anyone else... Fixing these sort of warnings in existing stable releases however IMO causes more risk then necessary. -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
