On 08/07/11 17:28, Richard Quadling wrote:
On 8 July 2011 17:21, DIXON P.<paul.di...@durham.ac.uk> wrote:
Thanks Richard,
Renamed and attached.
-----Original Message-----
From: Richard Quadling [mailto:rquadl...@gmail.com]
Sent: 08 July 2011 17:13
To: DIXON P.
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width,
height, type and attributes
On 8 July 2011 17:10, DIXON P.<paul.di...@durham.ac.uk> wrote:
Hi,
I've attached a patch ...
Rename as .txt to get through the mailing list s/w.
For consistency, should bits and mime become 4 and 5?
This would work in the same way as using named capturing in a regex,
where you get both the position index and the name in the result array
and I think various db_fetch_as_array type functions also.
It would be trivial to add 4, 5 and 6 for mime, channels and bits
respectively, and I can do that if people think that's best. However
personally long term, I would aim to remove the position index entries
completely.
Paul
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php