On Mon, Jul 11, 2011 at 11:09 PM, Hannes Magnusson <hannes.magnus...@gmail.com> wrote: > On Mon, Jul 11, 2011 at 22:13, Ferenc Kovacs <tyr...@gmail.com> wrote: >>> Stas means when we print who has voted, to only print votes by people >>> in that group so you won't need to manually filter out >>> not-allowed-to-vote votes. >>> >>> -Hannes >>> >> >> I see. >> if you only need the @php.net usernames, you can use the >> https://master.php.net/fetch/allusers.php api with the proper token, >> or https://bugs.php.net/js/userlisting.php without it. > > Or just ask the internal wiki api if the username is in the phpcvs/voted > group. > No need to make it complicated.
oh, I didn't though of that, as this is how my patch works (albeit only for the new votes, but still). :) > > The whole idea of this sort of workaround is however very silly to me. thanks for sharing, this kind of comments which keeps me contributing ;) ps: "The current vote still needs to be reviewed manually anyway, so I really don't understand the need for a quick hack at this time. Cooperating with the plugin authors on how to implement better checks there would imo make much more sense." I did this because it seems that some people use the current situation (that technically anybody can vote) as a cannon fodder for some personal arguments. the patch is as clean as it can be, and I asked you and others to review it before applying. of course the plugin author could do a better job, feel free to revert mine if we ever got that. -- Ferenc Kovács @Tyr43l - http://tyrael.hu -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
