Hi Rasmus, Thanks a lot for the response. This was the first email that I got that is not rude against my patch.
I have worked on Doctrine annotations support (which is being used by Symfony and also Typo3), which is a LL(*) parser that processes docblocks and uses runtime classes to build associated information. This relies on 2 points to correctly work: a reader and a cache. These ones are required for 2 reasons: - PHP doesn't currently support annotations (so ReflecionClass/ReflectionProperty/ReflectionMethod cannot have a simplified API to getAnnotations()). The Reader is a composition over ReflectionAPI. - Parsing is expensive and I cannot plugin opcache. To fix the overhead of processing every request, I plugged a cache support. What I thought it could be changed is: - Allow PHP to support it natively and also take advantage of opcode cache - Make API cleaner That's where the idea came. I voted for having it native to ZE because a code with and without comments should behave the same. So this made me to work on something that could be merged into php-src. If possible, could you look at the patch and give me high level ideas of what could be changed? Thanks On Mon, May 9, 2011 at 2:53 PM, Rasmus Lerdorf <ras...@lerdorf.com> wrote: > On 05/09/2011 10:48 AM, guilhermebla...@gmail.com wrote: >> >> Rasmus, >> >> I already wrote an RFC, I already wrote a patch and none from php-src >> gave me some valuable feedback. >> During private conversations while flaming messages were popping on ML >> thread, I updated the code to be more PHP compatible and when I went >> to update the RFC on wiki, it became offline. >> >> BTW, if you think Annotations wouldn't be so popular, please tell the >> Symfony users (Routing, Validation), Doctrine users (Entire Mapping), >> Typo3 users, Zend Framework (XML-RPC), PHPUnit users that this feature >> is useless. If this doesn't count 2000 users using the feature, I >> think only wordpress users may count this. > > Nobody has argued that there isn't a use for annotations. There obviously > is. The argument is whether it needs to be in the core of the language when > it isn't inherently a runtime thing. A single standard for annotations and > non-runtime tools for manipulating that standard is a viable approach as > well. That is what people are doing now, except they all picked different > ways of doing it. By putting it into the core you are solving that problem > since everyone will likely switch to it, but the argument is that that is > not a good enough justification for putting it into the core of the > language. > > -Rasmus > > -- Guilherme Blanco Mobile: +55 (16) 9215-8480 MSN: guilhermebla...@hotmail.com São Paulo - SP/Brazil -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
