2011/4/5 Sebastian Bergmann <sebast...@php.net>:
> On 04/05/2011 12:39 PM, Patrick ALLAERT wrote:
>>
>> They share nothing in terms of code
>
>  Question is: should debug_print_backtrace() not be refactored to reuse
>  code from zend_fetch_debug_backtrace()? That is why did not touch it
>  yet.

+1
I greatly share the refactoring need, I will see how this could be
done while providing as much internal API as possible so that
extension can benefit of.
I would, however, refrain from providing erroneous reflection information:

php --rf debug_print_backtrace
Function [ <internal:Core> function debug_print_backtrace ] {

  - Parameters [2] {
    Parameter #0 [ <optional> $options ]
    Parameter #1 [ <optional> $limit ]
  }
}

Patrick

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to