Chris and others, Since SNMP didn't have any unit tests to begin with, I just looked at some examples. I guess I looked at the wrong ones (in the current version 5811 unit tests have the SKIPIF sections, compared to 5416 that do not).
Before I start adding these, can someone tell me what to do to get this patch included? The maintainers of the SNMP extension have been silent so far. I would love to make this patch fly, but if it's just not going to happen then that's fine with me too. Regards, Jorrit Kronjee On 10/11/2010 04:37 PM, Christopher Jones wrote: > > Hi Jorrit, > > I'm not able to comment on the question of inclusion, but I did notice > that the .phpt > files are missing SKIPIF sections. See http://qa.php.net/write-test.php > > Chris > > On 10/11/2010 05:43 AM, Jorrit Kronjee wrote: >> Dear list, >> >> A few weeks ago I submitted the attached patch to this list. Apart from >> some initial comments I've not heard if the patch is good enough now to >> be added to the PHP sources. >> >> Is there anything still missing? >> >> Regards, >> >> Jorrit Kronjee >> > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
