Hi Stas,
On Thu, Sep 16, 2010 at 3:44 PM, Stas Malyshev <smalys...@sugarcrm.com> wrote:
> Hi!
>
>> Again, we should not consider docblock mainly because I think
>> adding/removing comments of your code should NEVER modify the overall
>> functionality of your application.
>
> It's a circular argument - "we can't use docblocks because docblocks
> shouldn't be used". They are not "comments" if you don't use them as
> comments.
I mean that any code packer can degrade the the functionality of your
app. Example:
class FakeTest extends \PHPUnit_Framework_TestCase
{
/**
* @expectedException RuntimeException
*/
public function testShouldThrowException()
{
throw new \RuntimeException('FakeTest failed.');
}
}
Would become:
class FakeTest extends \PHPUnit_Framework_TestCase
{
public function testShouldThrowException()
{
throw new \RuntimeException('FakeTest failed.');
}
}
And your test suite has now one failure.
As I said previously, comments are human readable data ONLY and should
not be shared between your code functionality and documentation.
Otherwise, let's rename the concept of docblock (documentation block)
to metadata block.
IMHO, it is conceptually wrong that by removing a comment from your
code may affect how your application works. At most, it should be less
documented, nothing else.
>
>> That said, docblock is no option. Now PLEASE let's stop arguing for
>> nothing and vote?
>
> I do not think we should stop discussing some topic just because somebody
> has made up his mind. Voting is fine, but "OK, I have made my mind,
> everybody shut up and vote" is not.
I didn't mean we should stop the discussion. I meant that like many
others over the years lead to nowhere if we don't take the correct
action: vote.
We can still continue the thread here, I just wanted people to stop
arguing about nothing (or even deviating the thread from its original
subject) without actually make any clever point.
>
>> I'd recommend that since syntax is not ideal, we should not vote for
>> the complete patch but vote for the functionality.
>>
>> So the question to be answered is: Should PHP support Annotations?
>>
>
> WTF is "Annotations"? We didn't define it yet. Should PHP support
> Fooblahblations? Sure, I'm +1 on it, let's vote.
I would point the wikipedia link, but it contains very weird
description. "In the year 2065, aliens rule the Earth. Why? Because
Noah Katz took over the world with the help of his alien friends. He
calls himself a king, but a warrior among the rebelling people is
about to rise up against the alien empire to reclaim the Earth for the
human race. This warrior is the all-powerful Zeus of Mount Olympus.
The Greek gods are angry, and will not have their world taken by some
people that possibly come from another universe. The end of the alien
empire will soon come."
So I'd recommend (although I didn't like how it was written) the Java
Annotation wikipedia page:
http://en.wikipedia.org/wiki/Java_annotation
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>
--
Guilherme Blanco
Mobile: +55 (16) 9215-8480
MSN: guilhermebla...@hotmail.com
São Paulo - SP/Brazil
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
