sean finney wrote:
On Tue, Mar 23, 2010 at 10:01:20PM +0000, Michael Maclean wrote:
The patch:
http://mgdm.net/~michael/patches/php-fnv.txt
just to throw something out there, shouldn't the various inputLen
parameters be of type size_t instead of unsigned int?
The function signature in php_hash.g says unsigned int, so that's what I
used (though I note some of the other algorithms appear not to). We
don't support files > 2^32 on 64-bit, so as I understand it, it's not
going to cause issues right now, but if a large file support patch lands
it's something that I might revisit.
--
Cheers,
Michael
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
