On Mar 22, 2010, at 10:55 AM, troels knak-nielsen wrote: > On Mon, Mar 22, 2010 at 4:55 PM, troels knak-nielsen <troel...@gmail.com> > wrote: >> On Mon, Mar 22, 2010 at 4:41 PM, Herman Radtke <hermanrad...@gmail.com> >> wrote: >>>> What do you mean by "no option"? Otherwise yes, that's what it does. >>> Using sleep there is not a good practice. Since the custom error >>> handler is triggered, there is no need for the sleep call anyways. >> >> So control isn't returned to the C-code before the php error handler >> finishes. Is that it? > > Just checked, and you're right about this. I've made a new patch, > which addresses this. Again, I have no idea about whether I'm > violating code style (Should zend_timeout_softswitch be declared or > named differently?), so comments on that please? > > New patch attached - disregard the previous one. >
Statics are bad, if its in multithreaded mode and two timeouts happen at once you'll get some funny behaviour. You need to store this in the thread local storage so the flag is per thread. Scott -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
