hi, CCing Ilia and Johannes as Andrei "discussed with the RM offline", I suppose it is Ilia, but Johannes is the 5.3 RM.
For the record, this fix is about using size_t in the SAPI to fix issues with uploaded files > 2G. While wondering what was the reasoning behind this commit, I came to the conclusion that we should not do such thing in stable branches and we should respect something we decided long time ago, to stop to add bad options which can break PHP ABI or BC in one way or another. It is especially important as we all know how distributors tend to deal with such options. The other reasons why I would like to revert this commit are: - not sure there are so many people uploading 2G+ files - 5.2 should really be in security fixes mode only - 5.3 should be in bug fixing mode only (without ABI breaks, even optional :) Opinions? Cheers, On Thu, Mar 18, 2010 at 10:07 PM, Andrei Zmievski <and...@php.net> wrote: > andrei Thu, 18 Mar 2010 21:07:38 +0000 > > Revision: http://svn.php.net/viewvc?view=revision&revision=296358 > > Log: > Fix a few problems with large (2G-4G) file uploads. Added > --enable-large-uploads-fix switch because one change was in SAPI.h structure. > > Changed paths: > U php/php-src/branches/PHP_5_2/configure.in > U php/php-src/branches/PHP_5_2/ext/standard/file.c > U php/php-src/branches/PHP_5_2/main/SAPI.c > U php/php-src/branches/PHP_5_2/main/SAPI.h > U php/php-src/branches/PHP_5_2/main/rfc1867.c > U php/php-src/branches/PHP_5_3/configure.in > U php/php-src/branches/PHP_5_3/ext/standard/file.c > U php/php-src/branches/PHP_5_3/main/SAPI.c > U php/php-src/branches/PHP_5_3/main/SAPI.h > U php/php-src/branches/PHP_5_3/main/rfc1867.c > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
