On Fri, Mar 12, 2010 at 8:39 PM, Alexey Zakhlestin <indey...@gmail.com> wrote: > > On 12.03.2010, at 22:23, Pierre Joye wrote: > >> On Fri, Mar 12, 2010 at 8:10 PM, Alexey Zakhlestin <indey...@gmail.com> >> wrote: >>> >>> On 12.03.2010, at 22:06, Pierre Joye wrote: >>> >>>> Many tests fail because they are written for a given platform, or even >>>> worst (from a portability point of view), only for a given >>>> configuration (library version, system version,etc.). And that's not >>>> about windows vs other, tests can work on a Debian/ubuntu version and >>>> fail on another. >>> >>> Well, these tests should just be removed/rewritten. >>> Php-tests should test php, not libraries >> >> I would be interested to know how can we test the file API without >> testing libc, for example. > > see my reply to Stas. > > The idea is to test things which we can guarantee. If our documentation says, > that function does this or that, then we should check for it and wrap > system-calls in such way, that our "file API" always does these things or > fails in strict predictable manner. > And if we can't guarantee some behaviour then we should add corresponding > note to documentation and we shouldn't add tests.
That's exactly (for part of the needs) what I describe in the 2nd part of my reply. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
