Jani Taskinen wrote: > On 01/17/2010 05:19 AM, Raphael Geissert wrote: >> Jani Taskinen wrote: >> >>> 16.1.2010 20:10, Raphael Geissert wrote: >>>> Some of the other patches include: >>>> libdb_is_-ldb >>> >>> Why? Potentially breaks things when you assume db/ being correct place.. >> >> Do you have an example of any actual case? > > Do you have an example where it's actually needed?
Yes, every time a new libdb version is released we would have to patch the config.m4 file. Instead, what this patch does is make the config.m4 pick the versionless files. For example, 5.3.1's ext/dba/config.m4 only knows up to db4.6 but at Debian we have already moved to 4.7 and are switching to 4.8. >> Can you tell me what exactly we are breaking? divert calls should only be >> used internally by autoconf and the, apparently useless, usage of them in >> php makes it fail to build with any other autoconf. > > If you remove them, things break. I don't remember right now why, but it > did, Rasmus tried this already and failed. Search the mailing lists for > more. His commit message is a bit weird, I think it should say "2.6x is > broken in so many ways" rather than 2.13: > > http://svn.php.net/viewvc?view=revision&revision=291414 > Well, we use autoconf2.63 (2.13 is soon to be dropped) and we need those changes to make it work. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
