Hi Pierre,

> slow (as you noticed). However it can't be done in 5.3 as it will
> break the ABI.
>

I noticed that a recent fix (http://bugs.php.net/bug.php?id=49936)
added TSRMLS_DC to an API in 5.3.
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/main/streams/php_stream_context.h?r1=290796&r2=290795&pathrev=290796

Wouldn't that need to be reverted as it breaks the ABI?

> About the patch itself, as it will break ABI anyway, I would go wit
> the solution 1) only. That's cleaner and consistent with what we
> usually do.
>

Ok, I'll get rid of the _ prefix diffs. Do my approaches (3) (4) for
varargs look ok?

Thanks for your review.

arvi

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to