Hi!
If you enable error log you would be able to identify errors, even in legacy code fairly quickly and address them as needed. The speed increase, by Stas' own admission is very minimal here, I would wager
It's not "very minimal". It's not big overall, but it speeds up operations affected 300-400%. Can you propose many other changes that would speed up any set of opcodes 300% in 10 lines of patch? ;)
saving memory and eliminating what effectively is a NOOP is a good idea, making it a configurable, user settable option, will simply lead to much abuse.
There would be no "abuse" that is not happening today, in almost every production install on Earth. Through the whole scenario you have consistently ignored the fact that we talk about errors that are *ignored* today, and only evidence of their general existence somewhere in the code is the slowdown - which is not measurable anyway, since there's no base for comparison, since there's no way to run _without_ the slowdown without this patch.
If the ultimate goal here is to save memory, why not simply set the mask to 0, which if understand Stas' original message correctly would equate its value to whatever the error reporting is set to.
You can, of course. But, as I explained, because there could be scenarios when you (ok, not you, somebody else) would want to use advanced tools which do not use error_reporting setting but have their own decision mechanisms, and you may be ready to pay the memory/speed penalty, say, for more accurate error statistics, etc. - at least temporary or on the part of your setup.
-- Stanislav Malyshev, Zend Software Architect s...@zend.com http://www.zend.com/ (408)253-8829 MSN: s...@zend.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
