Stanislav Malyshev wrote:
You just did safe_address in _safe_malloc(nmemb, len, 0) which should have called E_ERROR if nmemb*len overflows, so do you need to do it again?
Leaving a comment about it wouldn't hurt though :)

Yeah, you're right, but I didn't write the code. :) Regardless, I think this fix should go into 5.2/5.3 because calloc() advertises memory clearing as part of its API contract.

-Andrei

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to