Btw, replied to one big patch but the following is the one that caught my attention: "- Windows ACL cache support, update existing tests and add a new one"
I'm all in favor of having such a cache given Windows file system has been such an impediment on performance but this is not a patch that should go in at a late RC stage or even at any stage in an RC as they take some time to stabilize. Andi -----Original Message----- From: Andi Gutmans [mailto:a...@zend.com] Sent: Monday, June 15, 2009 10:37 PM To: Pierre-Alain Joye Cc: internals@lists.php.net Subject: [PHP-DEV] RE: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug41874.phpt bug47767.phpt link_win32.phpt TSRM tsrm_virtual_cwd.c This really does not look like a very safe commit at this point in the RC cycle. These kind of patches are very challenging and can affect behavior of applications. They are affected by many things incl. user permissions, CIFS, applications that move files, and more... I am sure you have tested it quite a bit but my experience with these kind of patches is that they take a long time to iron out. My recommendation for RMs is not to accept or push out the release if we do. Andi -----Original Message----- From: Pierre-Alain Joye [mailto:paj...@php.net] Sent: Monday, June 15, 2009 5:14 PM To: php-...@lists.php.net Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug41874.phpt bug47767.phpt link_win32.phpt TSRM tsrm_virtual_cwd.c pajoye Tue Jun 16 00:13:56 2009 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/file bug47767.phpt Modified files: /TSRM tsrm_virtual_cwd.c /php-src/ext/standard/tests/file bug41874.phpt link_win32.phpt Log: - #47767, include_once does not resolve windows symlinks or junctions -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
