Hello list,
I'd like to adapt ext/ldap for
(1) PHP 6
(2) bug #48441.
I also have at my disposal more than 80 phpt tests files for ext/ldap
that I will commit too.
In order to address this issues I'd like to have your review on the
following patches before I commit them:
(a) Refactoring of php_ldap_do_search() which also simplifies (b) and (c):
- Common cleanup section at the end of the function to avoid
duplicating cleaning logic.
- Logic specific to parallel/non-parallel search implemented inside
*one* "if (parallel search) {...} else {...}" block.
Patch:
http://87.98.252.90/01-ldap_refactor.patch.txt
http://87.98.252.90/01-ldap_refactor.patch.ignoreSpaceChanges.txt
(diff -bB version, easier for review-only)
(b) Converting ext/ldap to work with PHP 6:
Patch:
http://87.98.252.90/02-ldap_unicode.patch.txt
(c) Fixing #48441:
Patch:
http://87.98.252.90/03-ldap_bug48441.patch.txt
All of them should be committed to HEAD
(a) and (c) should be committed in addition to PHP_5_3 and PHP_5_2
(with adaptations).
You can test them with:
http://testfest.php.net/repos/testfest/BelgiumUG/ext/ldap/tests/
Thanks for your feedback :)
Cheers,
--
Patrick Allaert
---
http://patrickallaert.blogspot.com/
http://code.google.com/p/peclapm/ - Alternative PHP Monitor
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
