Hi Andrei, all,
----- Original Message -----
From: "Andrei Zmievski"
Sent: Wednesday, June 03, 2009
Matt Wilmas wrote:
[...]
Patches:
http://realplain.com/php/binary_eval_string.diff
http://realplain.com/php/binary_eval_string_5_3.diff
Can they be applied? (Also a small optimization by eliminating strlen()
usage.) May want to verify the ext/interbase change.
Yes, apply them (though I didn't verify the interbase patch).
All right. :-)
I noticed there are several zend_eval_string() references in PECL sources
[1], which would be a problem after adding a string length parameter...
How is that handled? Should the updated function be eval_stringL instead
and add macros for compatibility?
I'd prefer that.
It seems the TSRMLS params would be an issue with macros (or am I not
thinking right?), so I just used wrapper functions... Patches are
updated -- didn't check changes yet, but hopefully I didn't miss anything.
-Andrei
Thanks,
Matt
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
