Hi Jani,
----- Original Message -----
From: "Jani Taskinen"
Sent: Monday, May 11, 2009
Before committing anything else into PHP_5_3, can you first make sure
everything you provided is ALSO IN HEAD?!
To answer that directly, no. :-) Everything I do is in HEAD first, of
course, to keep things correct and in sync. But I'm not going to go and
update HEAD on behalf of someone else right at this time, which has been
missing forever, when things are trying to be finished up for 5.3.
Hint: zend_operators.*
(I noticed your recent cleanup stuff, and thought "He has to notice.")
I'm very well aware of anything I was involved with that has or hasn't been
done (no hints needed). ;-) Like many, many, many things that are (I don't
think it's "were?") out-of-sync, Ilia can take credit for that! Off-list
message from him Jan 18, 2007, after asking about when HEAD would be
updated: "The PHP 6 patches are up to Andrei to approve and commit, I am
only looking over the 5.2 tree and occasionally the 4.4 tree as well." That
was 16 months before I had a CVS account... The patch is still there [1],
unchanged from that day, if someone wants to take it, update and apply or
whatever before I get to it sometime after 5.3-critical stuff, I guess.
I *despise* these screwed up commits to wrong branches, so you'll never
catch me doing one. And I like bunnies too much (actually, don't care much
either way, but that sounds nice. :O)). I'd vote for karma removal until
people can learn to do stuff correctly; you'd probably agree.
[1] http://realplain.com/php/is_numeric.diff
--Jani
- Matt
Matt Wilmas kirjoitti:
Hi Lukas,
----- Original Message -----
From: "Lukas Kahwe Smith"
Sent: Monday, May 11, 2009
[...]
Critical issues:
1) I assume the issues with rounding are resolved. If any issues pop
up again, please let the list know.
@Matt/Dmitry: Can you just give us the quick nod that all is well here?
No, can't say that all is well. :-/ Nothing was changed yet, sorry if
you misunderstood. (BTW, it's not rounding/parsing, but
conversion/casting of floats->integers... :-))
I sent the updated patch a month ago, and then the next week Stas asked
some questions off-list, for clarification, etc. and then said that the
patch "looks good" and "since it appears to fix things I think it can be
applied." That's the only feedback I had really, and Dmitry mentioned
that it "breaks" about 30 tests (I'd consider them broken now, to match
the code, however ;-)), which I knew would have to be updated. I didn't
try to fix them yet, since I didn't know if the changes would finally be
applied or not. I was going to bring it up again but then it was too
close to RC2.
There were some e-mails on the subject that I didn't follow up on
(nothing major, just comments), including one of yours I think. Anyway,
I guess I/we can wonder about RC3 now? Again, the *very minor*
modifications only help to ensure the [usual] long-standing behavior on
all platforms -- e.g. most users would see no change from 5.2 or prior.
I'll try to be sure to do what I can to take care of anything now, since
I shouldn't be distracted with other stuff like leading up to RC2...
[...]
regards,
Lukas Kahwe Smith
m...@pooteeweet.org
- Matt
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
