On 02.04.2009, at 19:33, Johannes Schlüter wrote:
Hi,
On Wed, 2009-04-01 at 20:47 -0700, Justin Martin wrote:
The update I'd like to propose is to the Zend Highlighter for PHP,
specifically related to the highlight_file and highlight_string
functions, as well as the php -s command.
I don't see the need for a rush (or in other words: 5.3 can happily
live
without it imo) and for the general consideration there's still my
patch
from 2005 using a <ol> to have line numbers and adding id's so lines
can
directly be accessed by an URL.
http://schlueters.de/~johannes/php/zend_highlight_20050312_1.diff
About ini settings: We should avoid adding them as much as possible,
making this an ini setting gives you trouble in case the admin plays
with them for some reason and you don't overwrite them in the
script, on
the other hand it's the only way to make it work with "php -s" and the
apache sapi's application/x-httpd-php-source.
So in summary: Let's think carefully about this before committing the
first idea which comes to mind.
+1 .. lets get this sorted out in HEAD. Both the styling and the
optional support for line numbers and anchors.
As for Chris Stockton's proposal for simply having an array parameter
with predefined keys, is this the first time we are starting to feel
the need for named parameters in a real world example of something to
be added to core? I know that several users have proposed such a
feature before, but imho before we start adding arrays as a poor mans
named parameter support, we might want to open that pandoras box
again. Again nothing for 5.3 .. HEAD is where its at.
regards,
Lukas Kahwe Smith
m...@pooteeweet.org
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
