On Tue, Dec 9, 2008 at 19:54, Gregory Beaver <[EMAIL PROTECTED]> wrote: > Hannes Magnusson wrote: >> bjori Tue Dec 9 13:02:40 2008 UTC >> >> Modified files: (Branch: PHP_5_3) >> /php-src/ext/phar/tests ini_set.phpt >> Log: >> MFH: fix test >> >> >> http://cvs.php.net/viewvc.cgi/php-src/ext/phar/tests/ini_set.phpt?r1=1.4.2.1&r2=1.4.2.2&diff_format=u >> Index: php-src/ext/phar/tests/ini_set.phpt >> diff -u php-src/ext/phar/tests/ini_set.phpt:1.4.2.1 >> php-src/ext/phar/tests/ini_set.phpt:1.4.2.2 >> --- php-src/ext/phar/tests/ini_set.phpt:1.4.2.1 Fri Aug 1 13:38:47 >> 2008 >> +++ php-src/ext/phar/tests/ini_set.phpt Tue Dec 9 13:02:40 2008 >> @@ -25,7 +25,7 @@ >> string(1) "1" >> string(1) "1" >> string(1) "1" >> -string(1) "1" >> -string(1) "1" >> +bool(false) >> +bool(false) >> string(1) "1" >> string(1) "1" > > Hi, > > Heads up: there have been several commits to ext/phar in php-src by > non-maintainers who did not merge to pecl/phar, and a couple to > pecl/phar that were not merged to php-src. > > You have 2 choices. > > 1) merge that sucker > 2) email all of the phar maintainers whenever you do a commit so we at > least know about it and can do the merge. > > php-src/phar HEAD/PHP_5_3 and pecl/phar are intended to be 100% in sync.
What about 5.2? I thought the extension was supposed to work fine there too (at least there are bunch of tests that skip with the reason "needs 5.2"). So you have three branches in pecl? HEAD, PHP_5_3 and PHP_5_2? (Not that fix is required in 5.2, everyone who did try this functionality ignored the obvious wrong return value and committed the tests as-is and now 5.2 is apparently in security/critical-bugfix-mode-only.) -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
