While overall solid, I have 1 api critique that may or may not influence
inclusion..
The naming's seem slightly awkward for HttpResponse. Seemingly,
HttpResponse is the compliment to HttpRequest given their namings. But
looking at the api (the fact that its all static methods), it leads me
to believe that this class is more closely tied to the CURRENT PHP
response buffer. Is this the case?
While looking at the API for HttpRequest, it appears that after a
request is sent, it retrives an HTTPMessage object back (which would
make that class the compliment in the Request/Response paradigm).
If so, perhaps an alternate API and naming could be suggested?
HttpCurrentResponse makes alot of sense to me (as to not imply itself as
HttpRequest's compliment).. Also, would it make any sense (in this
case), to change the API to non-static methods, and object instantiation
to a getInstance() singleton pattern? This would allow for the class to
be extended and decorated and would be given more of an "object" feel-
which i feel like this the real value added here.
Please correct me if I am wrong,
Thanks,
Ralph
Hannes Magnusson wrote:
On Tue, Sep 23, 2008 at 13:54, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote:
I have not talked to Johannes about this, but unless there is a major major
major outcry from the internals folks to add it, its too late for 5.3.
I count one "vote" against it...
-Hannes
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
