Dmitry Stogov wrote:
I see several issues with the patch
1) It assumes that web server (and webserver extensions) won't setup any
signal handlers after PHP startup. This assumption may be wrong.
It may be. But there is really no way around that. That's why we
talked about having an optional request shutdown check that would tell
you if something hi-jacked one of the signals so at least you know that
this is happening.
2) It is incompatible with ext/pcntl
3) It breaks 3 tests (in debug mode)
tests/classes/destructor_visibility_001.phpt
tests/func/005a.phpt
ext/standard/tests/general_functions/phpinfo.phpt
4) I would also see the patch for HEAD (to commit them together)
I think it's not a good idea to commit it in this state.
Correct me, if I'm wrong. I've done just a very quick review.
It is much better than what we have now. We currently have nothing that
provides any sort of critical section protection from signals. This
patch at least gives us this for most cases. The exceptions being weird
extensions that set their own signal handlers and pcntl stuff that tries
to fiddle with them directly. But in both cases I would argue that you
get what you deserve if you are doing that.
-Rasmus
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
