2008/5/30 changelog <[EMAIL PROTECTED]>:
> changelog               Fri May 30 01:31:50 2008 UTC
>
>  Modified files:
>    /php-src    ChangeLog
>  Log:
>  ChangeLog update
>
> http://cvs.php.net/viewvc.cgi/php-src/ChangeLog?r1=1.3061&r2=1.3062&diff_format=u
> Index: php-src/ChangeLog
> diff -u php-src/ChangeLog:1.3061 php-src/ChangeLog:1.3062
> --- php-src/ChangeLog:1.3061    Thu May 29 01:31:48 2008
> +++ php-src/ChangeLog   Fri May 30 01:31:49 2008
> +2008-05-29  Scott MacVicar  <[EMAIL PROTECTED]>
> +
> +    * (PHP_5_2)
> +      NEWS
> +      TSRM/tsrm_win32.c:
> +      MFH: Fix a bug when command is quoted and parameters are quoted during 
> call
> +      to exec, the result is that cmd.exe /c strips the first and last quote.
> +
> +    * (PHP_5_3)
> +      TSRM/tsrm_win32.c:
> +      MFH: Fix bug when command is quoted and parameters are quoted during 
> call
> +      to exec, the result is that cmd.exe /c strips the first and last quote.
> +
> +    * TSRM/tsrm_win32.c:
> +      Fix bug when command is quoted and parameters are quoted during call to
> +      exec, the result is that cmd.exe /c strips the first and last quote.
> +

Hi.

This broke phd builds for, erm, ahem, (quietly ...) windows.

I've patched phd for PHP Version < 5.2.7, but Hannes asked if this
would be better left as is in 5.2 and only fixed in 5.3+

That way it can be documented as a change from 5.2.x to 5.3.0

Personally, I love the fix. I now have the same exec statements for
windows and unix. We are in sync!

But as Hannes put it IIRC ...

"bjori> RichardQ: which means that the fix broke 10years worth of
userland windows fixes"

Hm. Can't please all the people all the time!

Richard.
-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to