Thanks Dmitry!
----- Original Message -----
From: "Dmitry Stogov" <[EMAIL PROTECTED]>
To: "Steph Fox" <[EMAIL PROTECTED]>
Cc: "internals" <internals@lists.php.net>
Sent: Wednesday, March 12, 2008 8:54 AM
Subject: [PHP-DEV] RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /
zend_API.c zend_builtin_functions.c zend_compile.h zend_execute.c
zend_execute.h zend_execute_API.c zend_globals.h zend_vm_def.h
zend_vm_execute.h zend_vm_execute.skl zend_vm_gen.php /tests
Sorry for dealy.
It must be fixed now.
Thanks. Dmitry.
-----Original Message-----
From: Steph Fox [mailto:[EMAIL PROTECTED]
Sent: Monday, March 10, 2008 7:26 PM
To: Dmitry Stogov
Cc: internals
Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /
zend_API.c zend_builtin_functions.c zend_compile.h
zend_execute.c zend_execute.h zend_execute_API.c
zend_globals.h zend_vm_def.h zend_vm_execute.h
zend_vm_execute.skl zend_vm_gen.php /tests
Hi Dmitry,
I finally got around to upgrading my compiler over the
weekend, but I still
have to fiddle with line 229 of zend_execute.h to get sane
nmake output in
the 5_3 branch. And I'm not alone - see
http://snaps.php.net/win32/snapshot-5.3.log, now it's back
up. The only
place it doesn't throw a warning is in the debug build.
Can you please fix it?
Thanks,
- Steph
ps Sorry for top-posting, the alternative didn't bear thinking about.
> Oh. I meant MSVC6-SP5.
> Could you please verify the version with "cl" command.
>
> Dmitry.
>
> Steph Fox wrote:
>> But not MSVC6?
>>
>> Why would I get a compiler warning and you not? That
doesn't make a
>> lot
>> of sense.
>>
>> ----- Original Message ----- From: "Dmitry Stogov"
<[EMAIL PROTECTED]>
>> To: "Steph Fox" <[EMAIL PROTECTED]>
>> Cc: "Dmitry Stogov" <[EMAIL PROTECTED]>;
<[EMAIL PROTECTED]>
>> Sent: Thursday, January 24, 2008 4:18 PM
>> Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /
zend_API.c
>> zend_builtin_functions.c zend_compile.h zend_execute.c
zend_execute.h
>> zend_execute_API.c zend_globals.h zend_vm_def.h zend_vm_execute.h
>> zend_vm_execute.skl zend_vm_gen.php /tests
>>
>>
>>> I tried MSVC5 too. no warnings.
>>>
>>> > cl
>>>
>>> Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 12.00.8804
>>> for
>>> 80x86
>>> Copyright (C) Microsoft Corp 1984-1998. All rights reserved.
>>>
>>> Dmitry.
>>>
>>> Steph Fox wrote:
>>>> MSVC6 - which is still used for official php.net builds + snaps
>>>> because
>>>> everything Apache not CGI/CLI fails otherwise.
>>>>
>>>> Configure line is: --with-bz2 --enable-phar
--enable-zip=shared. I
>>>> don't recommend trying that @ present (phar build's
broken for me) but
>>>> I think you'll agree it doesn't affect ZE warnings.
>>>>
>>>> - Steph
>>>>
>>>>
>>>>> Hi Steph,
>>>>>
>>>>> What compiler/configure option do you use?
>>>>> I don't have such warnings.
>>>>>
>>>>> Thanks. Dmitry.
>>>>>
>>>>> Steph Fox wrote:
>>>>>> Hi Dmitry,
>>>>>>
>>>>>> This change led to an interesting make output here. The whole
>>>>>> thing
>>>>>> looks like this throughout:
>>>>>>
>>>>>> Zend\zend_execute.h(229) : warning C4018: '>' : signed/unsigned
>>>>>> mismatch
>>>>>> sanitizing_filters.c
>>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :
signed/unsigned
>>>>>> mismatch
>>>>>> ftp.c
>>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :
signed/unsigned
>>>>>> mismatch
>>>>>> php_ftp.c
>>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :
signed/unsigned
>>>>>> mismatch
>>>>>> hash.c
>>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :
signed/unsigned
>>>>>> mismatch
>>>>>> hash_adler32.c
>>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :
signed/unsigned
>>>>>> mismatch
>>>>>> hash_crc32.c
>>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :
signed/unsigned
>>>>>> mismatch
>>>>>> hash_gost.c
>>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :
signed/unsigned
>>>>>> mismatch
>>>>>>
>>>>>> I wasn't aware of zend_execute.h being called so many
times until
>>>>>> now, but maybe that's just because there's a warning
now that wasn't
>>>>>> there before? I can kill the warning easily enough:
>>>>>>
>>>>>> ZEND_VM_STACK_GROW_IF_NEEDED((int)size);
>>>>>>
>>>>>> but I've no idea if that breaks anything delicate.
>>>>>>
>>>>>> - Steph
>>>>>>
>>>>>>
>>>>>> ----- Original Message ----- From: "Dmitry Stogov"
>>>>>> <[EMAIL PROTECTED]>
>>>>>> To: <[EMAIL PROTECTED]>
>>>>>> Sent: Thursday, January 24, 2008 9:41 AM
>>>>>> Subject: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /
zend_API.c
>>>>>> zend_builtin_functions.c zend_compile.h zend_execute.c
zend_execute.h
>>>>>> zend_execute_API.c zend_globals.h zend_vm_def.h
zend_vm_execute.h
>>>>>> zend_vm_execute.skl zend_vm_gen.php /tests
bug41209.phpt php-src NEWS
>>>>>>
>>>>>>
>>>>>>> dmitry Thu Jan 24 09:41:41 2008 UTC
>>>>>>>
>>>>>>> Modified files: (Branch: PHP_5_3)
>>>>>>> /php-src NEWS
>>>>>>> /ZendEngine2 zend_API.c zend_builtin_functions.c
zend_compile.h
>>>>>>> zend_execute.c zend_execute.h
zend_execute_API.c
>>>>>>> zend_globals.h zend_vm_def.h zend_vm_execute.h
>>>>>>> zend_vm_execute.skl zend_vm_gen.php
>>>>>>> /ZendEngine2/tests bug41209.phpt
>>>>>>> Log:
>>>>>>> Changed EG(argument_stack) implementation.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
-----------------------------------------------------------------
>>>>>> ---------------
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> --
>>>>>>> Zend Engine CVS Mailing List (http://cvs.php.net/)
>>>>>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>>>>
>>>>
>>
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
