Hi Pierre,

Am Montag, den 11.02.2008, 17:42 +0100 schrieb Pierre Joye:
[...]
> Looks better :)

Thank you!

> I did not test it but it looks good. Did you run the tests suite?
> 
> +     dirname = estrndup(filename, strlen(filename));
> +     zend_dirname(dirname, strlen(dirname));
>
> One strlen can be dropped here.

Ah, good hint. See  http://lars.schokokeks.org/php/dir-constant-5.diff
for the corrected version.

cu, Lars

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

Reply via email to