On Oct 15, 2007, at 1:41 PM, Stanislav Malyshev wrote:
I didn't dive yet too deep into the patch, but shouldn't it be fixed on stream level and not function level? I.e. there are a lot of functions using streams (including files) - would they support bigger files too?
Yes, the patch does that; it turns on LFS in the headers, which promotes the off_t and size_t types that are used by streams to the 64-bit versions. This is the one liner in configure.in. The other larger part of the patch is to make PHP functions capable of returning and accepting numbers that are too big to fit into a long.
I also think that while using size_t is good, changing binary structures might be rather dangerous, unless we can ensure all PHPs built on the certain platform would use the same setting.
That's why 5.3 is a good point to apply this patch, rather than sneaking it into 5.2.x
--Wez. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
