Hello David, Monday, October 1, 2007, 11:36:19 PM, you wrote:
> Hi internals, > once again a proposal for a bugfix. > This time concerning http://bugs.php.net/bug.php?id=40501. > As the standard escape character is \\ , but the RFC says ", I added a > optional escape character to the function call as a last parameter. > Furthermore, when the escape character is the same as the enclosure > character (e.g. "), a "" string will be escape, while a single " will be > enclosured. > the patch and the according updated and added testfiles can be found at > http://experimentalworks.net/downloads/bug40501.patch.tar.gz > opinions? > greets > David Looks fine to me. And thanks for remembering to change SPL as well. While I looked at your patch I noticed that white space in your patch was not correct but in fact it looks like white space in all of SPL seems broken. So we should either fix WS before or after that patch. Best regards, Marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
