Michael Wallner wrote:
Nuno Lopes wrote:
nlopess         Fri Sep 14 15:28:04 2007 UTC

  Log:
  changes to run-tests.php:
  - change %s to %a
  - make %s = [^\r\n]+
  - fix tests accordingly

I think this is a very bad change.  While tests of bundled extensions
can be updated accordingly, pecl extension tests have no way to be
version agnostic in this regard.


Mike - that's a fair point. When we looked through the PHP tests we found that the vast majority (all except 4) relied on the %s behaviour as is is currently implemented - that is *not* matching over a line end. Only 4 tests were actually intentionally using %s to match over line endings. From what you say it sounds as though many more of the PECL tests behave this way?

Zoe Slattery

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to