Hello,
sorry for the late reply, I am on vacations these weeks and only have a
sparse access to web.
I was aware that my patch missed supports for callbacks, and let it that
way on purpose as I
planned to do some cleanup work on callbacks.
It looks like you placed the work necessary to have LSB in a different
place than mine,
generating more occurences and hence a quite bigger patch size. I'd like
to see what implications it has.
Sadly, the patch you gave me is not easily patchable with the current
HEAD, do you have an up to date version ?
Thanks in advance
Dmitry Stogov wrote:
Hi Etienne,
We already have patch for late static binding that is very similar to yours.
If you have time, please compare them.
>From quick look I see that our patch more accurate (it supports constants
and runtime function calls)
Does our patch miss something that your patch does?
Thanks. Dmitry.
-----Original Message-----
From: Etienne Kneuss [mailto:[EMAIL PROTECTED]
Sent: Friday, August 24, 2007 5:19 PM
To: internals@lists.php.net
Subject: [PHP-DEV] [patch] Late static bindings (LSB)
Hi internals,
here is a patch that implements Late static bindinds in a way that
minimizes the performance hits that were feared.
There is no significant slowdown or memory usage increase
when running
Zend/bench.php, which I assume is a
good enough bench for that kind of matter, as it involves a stupid
amount of (recursive) function calls.
You can also find the patch here:
http://patches.colder.ch/Zend/late_static_bindings_take6.patch?markup
Here is a document that describes its usage:
http://colder.ch/news/08-24-2007/28/late-static-bindings-expl.html
Regards,
--
Etienne Kneuss
http://www.colder.ch
Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal
--
Etienne Kneuss
http://www.colder.ch
Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
