Hi Andi, On Tue, 2007-08-14 at 09:13 -0700, Andi Gutmans wrote: > Yeah and we reviewed the patch and saw it was good.
Thanks for the feedback, such information is always appreciated :-) > I think what's missing here is that to the best of my knowledge Ilia > reached out off list to revert the patch but when that didn't happen > after 2-3 days it was reverted. So the missing link here is the offlist > email. It was definitely not a screw you... And the patch will go in > right after 5.2.4. Being the one who committed Etienne's patch a few moments before Ilia packaged the RC1, I guess I should have got it but I didn't see such an off-list message. (which might be a failure on my side, too, I was traveling and got quite some other messages, too) I think it would be good to send such messages to internals, too even so posts to internals tend to lead to big discussions (well, as some "random" revert might too...) johannes > > Andi > > > > -----Original Message----- > > From: Hannes Magnusson [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, August 14, 2007 12:31 AM > > To: Stas Malyshev > > Cc: internals@lists.php.net > > Subject: Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) > > / zend_language_parser.y > > > > On 8/14/07, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > > > > A Major bugfix maybe ( yes, it was clearly a bug/misfeature) > > > > > > A bug is when code doesn't do what was intended. This is not the > > case, > > > this is the case of missing feature. While I think everybody agrees > > this > > > feature is good to us, it's not the time to add it. We lived for > > years > > > without it, we can live for a couple more monthes :) > > > > I totally agree that major changes like this should not go into a > > minor bugfix releases. > > The revert however came out of nowhere and felt like a big fat SCREW > > YOU, ALL YOUR BASE ARE BELONG TO US. > > > > Andi wrote, 10 days ago, that he was OK with it if the patch was > > "decent > > (doesn't screw up common case and maintainability)" and was going to > > look at the patch better "tomorrow"... > > > > -Hannes > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
