Was there some particular reason to remove those ()'s around the macros?
(usually they're there for a reason :)

Also, extra ; is not needed and doesn't conform to the style of other PHP code. Macros usually don't need ; at the end.

Also, these:
+#define ZVAL_ADDREF(pz)                        ++(pz)->refcount;
+#define OBJ_ADDREF(obj)                        ++(obj)->refcount;
look quite confusing.

And, PHP usually doesn't have _NP macros. If you need pointer and non-pointer macro, do non-pointer one and add _P's to it.

--
Stanislav Malyshev, Zend Software Architect
[EMAIL PROTECTED]   http://www.zend.com/
(408)253-8829   MSN: [EMAIL PROTECTED]

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to