On Jan 27, 2007, at 9:15 AM, Andi Gutmans wrote:
Hi Sara,
I don't feel to great with this patch. It kind of feels like
twisting the language implementation around for some very specific
problem which probably shouldn't be fixed at this level. Andrei
says performance of Unicode isn't great so it shouldn't matter too
much, but I think a) it's not only about performance but also about
maintainability. The code in PHP 6 is already much more complex
than that of PHP 5 and has become much harder to maintain. Such
additional changes will make it worse b) There will still be plenty
of people who use PHP 6 in PHP 5 mode.
Compared to the overall complexity of the PHP 6 code, this is a minor
change.
I still haven't quite understood why not just do the detection on
the whole auto-global when it's being fetched (or even during
request startup). As Andrei said, it's slow anyway so for people
who need Unicode that should be an affordable hit.
Maybe I don't understand the problem in enough detail and it might
make sense for me to talk to Andrei via voice directly, but I
really don't think we should be over eager commiting this patch.
It'll not be good for the engine long term (not that I don't
appreciate your efforts and hard work on this patch).
Here is a link to a message Rasmus posted describing the problems
with JIT'ing the whole array at once.
http://marc.theaimsgroup.com/?l=php-dev&m=116624773928646&w=2
-Andrei
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
