On Fri, 22 Dec 2006, Ilia Alshanetsky wrote: > > On 22-Dec-06, at 10:56 AM, Hannes Magnusson wrote: > > > Hi Ilia, all > > > > This fix is incorrect.. > > %f became locale aware internally after the recent *printf changes > > causing all kinds of side affects like this one. > > Yes and no. We should still check for both . and , for fringe cases. > > > We should: > > a) revert that change (i.e. make %f not locale aware again) (see > > attached patch against 5_2) or > > b) keep %f locale aware internally and search our code base and change %f to > > %F > > I believe b is a better option in this case, I don't think BC should be a > problem in this case. But if there is a sufficient feeling that it maybe, > perhaps temporary solution could be option a.
It's a BC break for 3rd party extensions, and I don't think we should be breaking BC for that because it's such a pointless tiny change for them. regards, Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
