Hello,
On 10/11/06, Jasper Bryant-Greene <[EMAIL PROTECTED]> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Pierre wrote:
> Hello,
>
> On 10/11/06, Derick Rethans <[EMAIL PROTECTED]> wrote:
>> On Wed, 11 Oct 2006, Pierre wrote:
>>
>> > On 10/11/06, Derick Rethans <[EMAIL PROTECTED]> wrote:
>> > > On Wed, 11 Oct 2006, Pierre wrote:
>> > >
>> > > > Doing so you can distinguish invalid values from non existent
>> values.
>> > > > Boolean values are the only case where it is not possible to
>> > > > distinguish FALSE from invalid as they can be FALSE, but it is
>> really
>> > > > not an issue.
>> > >
>> > > If it wasn't an issue I wouldn't have fixed it.
>> >
>> > Ok, I have no time to argue again with you about that. I will revert
>> > it tonight so we will be ready for 5.2.0RC6.
>>
>> You will do no such thing. I am getting tired of your "but we agreed on
>> this", while that is just in your mind. I didn't agree in the first
>> place that you're changing the API since the original design so I feel
>> free to revert every non-discussed change that you made in the first
>> place.
>
> We discussed the changes. The changes have been in place since weeks,
> even before the last API changes (which was *again* done on *your*
> late request, respectless).
>
> If you consider last minute commit as the way to go with PHP, you are
> wrong.
>
> There is no trick in what was in place and I will restore it before
> RC6. I have enough of your attitude, you don't communicate, you don'd
> discuss, you don't respect anything or anyone. I cannot accept that
> anymore.
As a cool-headed outside observer... looking at the two possible APIs,
we have (correct me if I am wrong):
* Pierre's suggested API - returns FALSE in two possible situations with
no way to distinguish between the two.
* Derick's suggested API - returns NULL in two possible situations with
a clear way to distinguish between the two (function filter_has_var())
I think it is very clear which API is superior - in fact I would find
Pierre's API broken and unusable myself.
As my proposal clearly states when a value is set or not and what is
valid and what is not for all cases but boolean input values. For this
relatively rare case, yes, you can and should use filter_has_var (just
like anyone already does for radio or check boxes values), at least
anyone who already uses this extension.
--Pierre
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
