Hi there, OK, so overflows aren't very likely with MAX_LENGTH_OF_LONG set to 20, but I found 3 places I think you'll want to change. :-)
Also, can MAX_LENGTH_OF_LONG be changed to be accurate on 32-bit platforms? Is setting it to (sizeof(long) > 4 ? 20 : 11) acceptable? If MAX_LENGTH_OF_LONG is truely accurate, I can use it to optimize is_numeric_[string|unicode]() (and zend_u_strtod() too I think if it's not otherwise rewritten), and it saves a few bytes of memory on 32-bit systems. ;-) http://realplain.com/php/MAX_LENGTH_OF_LONG.diff http://realplain.com/php/MAX_LENGTH_OF_LONG_5_2.diff Thanks, Matt -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
