Yeah, that's probably a good idea. You can submit a patch if you want. :)

-Andrei


On Jul 21, 2006, at 6:04 AM, Matt W wrote:

Hi Richard,

I think I've seen those instances that you're referring to. By fixed length string I assume you mean hard-coded "string_key". Yeah, I would think those should use add_assoc_*_ex() since the length is known (sizeof ("string_key")
etc.) to save unnecessary strlen() calls.

Unless compilers optimize the strlen("string_key") + 1 to a constant from
the add_assoc_*() macro.  But I wouldn't think that's the case...? :-/


Matt


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to