I was having some problems testing in native mode when my ini file had unicode enabled. It appears that it must be explicitly disabled in the script with the passing -N flag (make ntest). Otherwise it is picking up the ini setting and running the tests in unicode mode. Patch is attached just in case I am missing something here about how ntest is supposed to work.

This also changes the use of single quotes to double quotes in a couple calls so the script is processed correctly under windows. Dont think this change will affect any systems, but it is needed to allow unicode testing on windows once enabled.

Rob
Index: run-tests.php
===================================================================
RCS file: /repository/php-src/run-tests.php,v
retrieving revision 1.297
diff -u -r1.297 run-tests.php
--- run-tests.php       17 Jul 2006 11:46:12 -0000      1.297
+++ run-tests.php       20 Jul 2006 02:15:38 -0000
@@ -179,9 +179,9 @@
        settings2params($info_params);
        $php_info = `$php $pass_options $info_params $info_file`;
        @unlink($info_file);
-       define('TESTED_PHP_VERSION', `$php -r 'echo PHP_VERSION;'`);
+       define('TESTED_PHP_VERSION', `$php -r "echo PHP_VERSION;"`);
 
-       $unicode = `$php $pass_options $info_params -r 'echo 
ini_get("unicode.semantics");'`;
+       $unicode = `$php $pass_options $info_params -r "echo 
ini_get('unicode.semantics');"`;
        define('TESTED_UNICODE', strcasecmp($unicode,"on") == 0 || $unicode == 
1);
 
        // load list of enabled extensions
@@ -333,6 +333,7 @@
                                case 'N':
                                        $unicode_and_native = false;
                                        $unicode_testing = false;
+                                       $ini_overwrites[] = 
'unicode.semantics=0';
                                        break;
                                case '--no-clean':
                                        $no_clean = true;

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to