Thank you for catching me.
Fixed.

Thanks. Dmitry.

> -----Original Message-----
> From: Frank M. Kromann [mailto:[EMAIL PROTECTED] 
> Sent: Tuesday, June 13, 2006 11:20 PM
> To: [EMAIL PROTECTED]
> Cc: internals@lists.php.net
> Subject: Last patch breaks ODBC
> 
> 
> Hi Dmitry,
> 
> Your last module cleanup patch seams to break compilation on 
> ext/odbc/php_udbc.c. Would it be safe to reverrt this? The 
> odbc module does not use global variables.
> 
> - Frank
> 
> 
> cvs diff -u -- php_odbc.c (in directory C:\PHP\php6\ext\odbc\)
> Index: php_odbc.c 
> ===================================================================
> RCS file: /repository/php-src/ext/odbc/php_odbc.c,v
> retrieving revision 1.195
> diff -u -r1.195 php_odbc.c
> --- php_odbc.c        13 Jun 2006 13:12:19 -0000      1.195
> +++ php_odbc.c        13 Jun 2006 19:16:16 -0000
> @@ -131,7 +131,6 @@
>  /* }}} */
>  
>  ZEND_DECLARE_MODULE_GLOBALS(odbc);
> -static PHP_GINIT_FUNCTION(odbc);
>  
>  /* {{{ odbc_module_entry
>   */
> @@ -145,8 +144,8 @@
>       PHP_RSHUTDOWN(odbc), 
>       PHP_MINFO(odbc), 
>       "1.0",
> -     PHP_MODULE_GLOBALS(odbc),
> -     PHP_GINIT(odbc),
> +     NULL,
> +     NULL,
>       NULL,
>       NULL,
>       STANDARD_MODULE_PROPERTIES_EX
> @@ -404,11 +403,6 @@
>  PHP_INI_END()
>  /* }}} */
>  
> -static PHP_GINIT_FUNCTION(odbc)
> -{
> -     odbc_globals->num_persistent = 0;
> -}
> -
>  /* {{{ PHP_MINIT_FUNCTION */
>  PHP_MINIT_FUNCTION(odbc)
>  {
> 
> 
> 
> 
> 
> 
> 

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to