Hello Christopher,
there's an interesting detail in you patch i never used in the for you
did: php_error_docref("function.pg-real-escape-bytea" ...) where the name
you passed in is different from the name of the function. That works as
expected? On the same thing, you say that the function is deprecated.
You may however want to flag the teh deprecated function using the
corresponding flag: ZEND_ACC_DEPRECATED.
Rest looks correct - of course.
best regards
marcus
Monday, May 29, 2006, 8:02:57 AM, you wrote:
> As a follow up I've attached my initial patch for this. Can people
> please review?
> Chris
> Christopher Kings-Lynne wrote:
>> Hi,
>>
>> I'm starting on a pg_real_escape_string and pg_real_escape_bytea
>> function for PostgreSQL, based on this security release:
>>
>> http://www.postgresql.org/docs/techdocs.49
>>
>> Is anyone else working on it, or is it fine that I do it? I'll let you
>> know if it's going to take me too long.
>>
>> Basically the new functions are analagous to the
>> mysql_real_escape_string function. The difference will be that the
>> pgsql function will have the optional DB connection resource as the
>> first parameter rather than the second. (Same as other pgsql functions)
>>
>> Any comments?
>>
>> There may be cause to backport these functions ... although the existing
>> pg_escape_string function is safe in a single threaded context. That's
>> your guys call.
>>
>> Chris
>>
Best regards,
Marcus
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
