On Sat, 13 May 2006, Marcus Boerger wrote: > the test is wrong. We just added a missing check in 5.2. That means it > is a non severe error already in 5.0 and 5.1. Just nobody told us about > yet. So please just drop the test case or even better fix it with the > expected error message. If this is a real issue for you company we could > go with a compromise and make it an E_STRICT in 5.2 and drop the *not bug > but feature* in 5.3/6.0. Since E:STRICT was all about notifying ppl about > future changes, wasn't it?
It doesn't really matter if this issue personally affect me or not. The thing is that this change is now breaking applications and I am probably one of the first to see it cause I keep running CVS all the time. I keep saying that there is no good reason NOT to allow "abstract static". The only reason that I heard so far from you is that it is not pure OO. So I think we should revert the change that makes this a fatal error. I also don't even think we should make this an e_Strict or even considering not allowing this at all, as there is IMO still nothing wrong by having an "abstract static" to make sure implemenations implement this method and an interface can not be used. regards, Derick > Friday, May 12, 2006, 12:02:13 PM, you wrote: > > > derick Fri May 12 10:02:13 2006 UTC > > > Added files: > > /ZendEngine2/tests abstract-static.phpt object-null.phpt > > Log: > > - Added tests for BC breaking changes. > > > > > > > http://cvs.php.net/viewcvs.cgi/ZendEngine2/tests/abstract-static.phpt?view=markup&rev=1.1 > > Index: ZendEngine2/tests/abstract-static.phpt > > +++ ZendEngine2/tests/abstract-static.phpt > > --TEST-- > > Test for abstract static classes > > --FILE-- > > <?php > > abstract class ezcDbHandler extends PDO > > { > > public function __construct( $dbParams, $dsn ) > > { > > $user = null; > > $pass = null; > > $driverOptions = null; > > } > > > abstract static public function getName(); > > > static public function hasFeature( $feature ) > > { > > return false; > > } > > } > ?>> > > DONE > > --EXPECT-- > > DONE -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
