Rasmus Lerdorf wrote:
I had another look at Joshua's upload progress patch:
http://pdoru.from.ro/upload-progress-meter/upload-progress-meter-v4.1/php-patch/patch.upload-progress-callback-v4.1-for-php5.0.3.txt
I seem to remember there being some valid reason for not adding this
patch, but looking over the code, it doesn't jump out at me. It seems
safe enough unless I am missing a subtle TSRM issue. Anybody remember
what the problem was?
There is variation here:
http://www.zend.com/zend/week/pat/pat23.txt
Quite similar. The one change I would make to both would be to put the
temp filename in the callback call so the extension on the other end has
a chance to keep track of which upload caused the callback to trigger in
a threaded environment with concurrent uploads.
-Rasmus
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
