Committed to HEAD.. I'll let the RM decide where this belongs for PHP 5.1+ before PHP 6 (5.2 probably) Sorry I misspelled your name in the commit ;)
John On Thu, 2006-03-23 at 12:16 +0100, Markus Fischer wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > okay, so with whom I've to sleep to get this patch in? :) > > cheers, > - - Markus > > Markus Fischer wrote: > > Hi, > > > > Antony Dovgal wrote: > >> On 25.01.2006 16:17, Markus Fischer wrote: > >>> the patch is in the bug report ( http://bugs.php.net/bug.php?id=34023 > >>> ) or do you meant something else? > >> > >> Jani meant that it would be better to put this patch as a downloadable > >> file (applying copy-pasted patches causes some problems with > >> tabs/whitespaces). > > > > As written in the other email, the path is online at > > http://www.zend.com/zend/week/pat/pat52.txt . > > > >> Also, some .phpt tests testing new method would be great. > > > > Thanks, I've attached a simple test to this email. > > > > - Markus > > > > > > ------------------------------------------------------------------------ > > > > --TEST-- > > Test getParent() > > --SKIPIF-- > > <?php if (!extension_loaded("tidy")) print "skip"; ?> > > --FILE-- > > <?php > > $x = tidy_parse_string("<body><div>Content</div></body>"); > > var_dump($x->body()->child[0]->getParent()->name); > > ?> > > --EXPECT-- > > string(4) "body" > > > > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.2.2 (MingW32) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQFEIoOg1nS0RcInK9ARAiQoAKCTDFX2S96rE9jj8dfplaaSWBbZDQCbBEwU > xkG9JkMubeZN33BCrWh/Deg= > =1niF > -----END PGP SIGNATURE----- > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php