Hello Andi, i don't see your point here. We've discussed this tons of times. Either fix the engine if you know it's broken, show us a real problem with the pacth or accept the fact that we want to make progress here. Blocking patches because they have a slight potential in causing some problems without telling about the problems and coming up with some test script doesn't help anybody here. You are just waisting my time with that. All other who saw the patch agreed to it already.
marcus Sunday, September 25, 2005, 6:31:59 PM, you wrote: > Give me a couple of days to review the patch itself. > I think we should then commit to HEAD, and see how it goes. There's > hopefully enough time in the PHP 6 process to validate that this kind > of patch doesn't hit any conceptual problems re: propagating to > pre-compile/post-shutdown execution stages... > Andi > At 05:36 AM 9/25/2005, Marcus Boerger wrote: >>Hello internals, >> >> the patch implements __toString to have obejcts be automatically converted >>to strings anywhere a string is requested. We have talked a lot about this >>in the past and during OSCON Andi agreed again on it and said that the HEAD >>version of the engine should be ready for it now. Futher more we have enough >>time to fix any outstanding engine issues regarding this. >> >> http://php.net/~helly/php/ext/ze2/ze2-tostring-20050925.diff.txt >> >> If nobody objects with a real technical issue i'll commit the patch early >>in the week. >> >> The patch is a little big longer because it ensures that __toString gets >>treated and especially gets cached just like any other magic function is. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
