On Tue, 9 Aug 2005, Rathna N wrote: > Sorry, I forgot to add subject line to the old mail.
the [EMAIL PROTECTED] list would be the best list for this subject. As for the tests, it would be nice if you could provide a unified diff against CVS's HEAD. That's much easier than have to download a .zip file - we can more easily check the test cases then. Some points on the tests: - please always use lower case filenames for the tests. - as --TEST-- name, please just use the name of the function, such as "jdtojulian()" (without any other description) - try always to cover edge cases in your tests. (For gregorian times, it makes sense to check what it does around the beginning of the gregorian calendar for example). - prefer var_dump() over print_r(). - Always use the ISO 8601 format for outputting date (if you're formatting them yourself). See easter_date.phpt f.e. - In easter_date.phpt, you'll have to check way more years - just testing 3 is not enough. - There is no --DESCRIPTION-- field as you used in GregorianToJD.phpt. - Always use <?php and not <? in test cases (see JDToJulian.phpt). - Please stick to the PEAR coding standards in your tests. And thanks for picking this up! But perhaps I can suggest to start with other more used extensions? Most of our string and array functions don't have enough testcases either. regards, Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
