Hi,
Attached is a patch that brings PostgreSQL support in PHP out of the stone age!
The patch looks great. Do you have a CVS account? If not, apply for one and I'll set you up with access to ext/pgsql so that you can commit and maintain that patch.
Should pg_query_params instead be folded into pg_query, with an optional 3rd parameter which would be the parameter array? Would this then be difficult for clients to detect if the 3rd parameter is available to them?
As you noticed, right now it's a problem. Lately I've been thinking about preparing infrastructure that will allow you to specify the mandatory/optional arguments in order (as you do today), but also an extra resource-type argument, that can appear anywhere in the argument list, and will be updated if it's found or NULL'd if it isn't. This will allow the concept of 'default resource' to work better with other optional (or newly introduced) arguments. I have to think about it some more and see if it's feasible. In the meantime, you should probably keep pg_query_params().
Zeev
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
