Hi Georg,

When we nuked the garbage collector this behavior was accidentally changed. I think it should be fixed in the Zend Engine so that extensions stay source compatible in between versions as much as possible.
Will look into it.


Thanks,

Andi

At 05:14 PM 12/3/2004 +0100, Georg Richter wrote:
Hi,

the following patch solves bug #28817 in HEAD.
However it doesn't work in 5_0 branch. In 5_0 I have to set
retval->refcount to 1 to get it work - any ideas what's going wrong ?!

Same behaviour in mysqli (which has a similiar property handling).

/Georg

Patch:

diff -u -r1.64 php_dom.c
--- php_dom.c   7 Oct 2004 11:40:20 -0000       1.64
+++ php_dom.c   3 Dec 2004 13:49:25 -0000
@@ -235,6 +235,7 @@
        } else {
                std_hnd = zend_get_std_object_handlers();
                retval = std_hnd->read_property(object, member, type
TSRMLS_CC);
+               retval->refcount = 0;
        }

        if (member == &tmp_member) {

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to