Hi everyone, I’m following up on the array_str_contains() RFC and would appreciate any feedback, especially regarding the proposed API and the real-world usage analysis.
The updated analysis shows that array_str_contains() can simplify up to 17 of the 32 identified patterns, while the remaining patterns contain additional logic and are not direct replacements. The CI test issue is being addressed separately by correcting the expected output in the .phpt test. Thanks for taking the time to review the proposal. Best regards, Sepehr در تاریخ دوشنبه ۳۱ اوت ۲۰۲۶، ۱۹:۵۲ سپهر محمودی <[email protected]> نوشت: > > > در تاریخ دوشنبه ۳۱ اوت ۲۰۲۶، ۱۸:۴۲ Tim Düsterhus <[email protected]> نوشت: > >> Hi >> >> On 2026-08-30 16:19, سپهر محمودی wrote: >> > You can check out the RFC and implementation details here: >> > - RFC: https://wiki.php.net/rfc/array_str_contains >> > - Pull Request: https://github.com/php/php-src/pull/23512 >> >> Don’t forget to add your RFC to the overview at >> https://wiki.php.net/rfc. >> >> As for the proposal itself, I agree with the existing replies that I >> don’t consider this to be a useful addition to PHP’s stdlib. See also my >> reply in the discussion thread about whether or not RFCs should include >> polyfills: https://news-web.php.net/php.internals/132402 >> >> Best regards >> Tim Düsterhus >> > > -------- > > Hi Tim, > > Thanks for the reminder! I will add the RFC to the overview page shortly. > > I also appreciate your feedback and insight regarding standard library > additions. I understand the perspective of keeping the stdlib concise and > relying on composable primitives like array_any(). > > Best regards, > Sepehr > >
