Hi
On 12/3/24 15:40, Daniel Scherzer wrote:
This is not just extensions, but also userland code that did not
anticipate any new attribute targets.
Given that
1. there isn't (as far as I know) a way to search for everything that has
an attribute
2. there isn't a current way to identify if a constant has an attribute
I didn't think there was anything to actually break for userland
attributes, but I've reworded the note to include userland attributes just
in case.
Here's an example of a userland library that collects attributes as a
“build time” step:
https://github.com/olvlvl/composer-attribute-collector
If that library is updated to understand attributes on constants and a
user applies a TARGET_ALL attribute on a constant, then this case would
apply.
Even if it ultimately is “just in case”, it’s nevertheless helpful to
spell out all possible caveats for the reader to make an informed
decision about the RFC. So thank you for the update :-)
------------
With the updated version, I don't have any further comments about your
RFC text.
Best regards
Tim Düsterhus
