On 17.09.2024 at 17:06, Derick Rethans wrote: > On Mon, 9 Sep 2024, Christoph M. Becker wrote: > >> write-test.php is important, and <https://qa.php.net/phpt_details.php> >> maybe even more so. As this is relevant for run-tests.php (I don't >> think there are still alternative test runners), php-src/docs seems to >> be a good home for it. > > I agree, it should go there. All the "read me" type docs are MD, but the > actual documentation in > https://github.com/php/php-src/tree/master/docs/source is (for good > reasons) in RST. I think it makes sense for the PHPT documentation > (write-test.php and phpt_details) to be a single ".md" in docs/ — one > explains the how and minimal how, whereas the latter is much more > detail).
I had already submitted PR #15939 before I read your reply, but I'm more than fine going with PR #15940 instead. >> handling-bugs.php needs a thorough overhaul, or might be dropped >> altogether. Some of the quickfix snippets might still be useful for >> the GH issue tracker, though. > > I say we just drop it. Okay. >> The PFTT reports have always been pretty much useless. >> <https://qa.php.net/reports/run_tests.php> had some value, but >> apparently the SQLite DB had been corrupted again, so this can >> probably be removed as well. I believe the functionality to send >> these reports has been dropped from run-tests.php quite a while ago >> anyway. > > I tried to see what was going on there, but on the command line, the > 8.2.18 file is fine (there is a file for every version). It's just an > empty database and the "reports" table doesn't exist. > > I have now removed the empty files, so the report works. > But I wouldn't say it's useful. I agree that it is preferable to have users open tickets on GH about failing tests; at least you can request feedback there. Christoph
